refactor: use header info for interchain accounts address generation #7713
Conversation
damiannolan
requested review from
AdityaSripal,
DimitrisJim and
gjermundgaraba
as code owners
There was a problem hiding this comment.
Looks good in principle. But my understanding is that we can just go back to deterministic address generation because addresses are no longer instantiated as base accounts on receive. So we no longer have to protect against DoS attacks with the new sdk changes
| buf = append(buf, header.AppHash...) | ||
| buf = append(buf, header.DataHash...) | ||
| buf = append(buf, headerInfo.AppHash...) | ||
| buf = append(buf, headerInfo.Hash...) |
There was a problem hiding this comment.
I guess we no longer get access to datahash directly? Is there a reason it isn't in header info?
There was a problem hiding this comment.
That's a question for the sdk team I think.
Agree! That skipped my mind about the removal of account creation from |
|
Description
Removes
UnwrapSDKContextfor interchain accounts.Now uses block hash (merkle root of block) instead of dataHash for interchain accounts address generation.
The
ctx.BlockHeaderis deprecated and recommended to now use service based approach. TheHeaderServiceprovided by cosmos-sdk returnsheader.Infowhich only containsappHash,hash(merkle root of block),height,timeandchainID.It is recommended to use
cometservicewhen anything else is needed.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.